This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Directly use FunctionBuilder when we do not need WasmExpressionBuilder. #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In addition to the likely performance benefit, it allows us to use them in constant expressions, without support for the expression builder. We use that opportunity when creating the field values in `newDefault` functions, like we already did for static fields.
Before, we created synthetic IR trees that we sent to the expression builder. Now, we instead directly emit the appropriate Wasm instructions. This adds a bit of duplication of logic on how arrays are built, but it removes the direct dependency of the `Emitter` on `WasmExpressionBuilder`.
This way, we use `WasmFunctionContext`+`WasmExpressionContext` only when we need to translate user-defined IR trees. In that case, the `WasmFunctionContext` is responsible for local name management: encoding from IR local names and generation of synthetic local names. Otherwise, when we generate Wasm code independent of IR trees, we directly use `FunctionBuilder`. Local name management is left to the user code.
sjrd
force-pushed
the
use-function-builder-when-we-can
branch
from
7d371bd to
dab625a
Compare
Merged
tanishiking
approved these changes
May 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way, we use
WasmFunctionContext+WasmExpressionContextonly when we need to translate user-defined IR trees. In that case, theWasmFunctionContextis responsible for local name management: encoding from IR local names and generation of synthetic local names.Otherwise, when we generate Wasm code independent of IR trees, we directly use
FunctionBuilder. Local name management is left to the user code.