Skip to content
This repository was archived by the owner on Jul 12, 2024. It is now read-only.

Upgrade to Scala.js 1.16.0. #25

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Upgrade to Scala.js 1.16.0. #25

merged 2 commits into from
Mar 18, 2024

Conversation

sjrd
Copy link
Collaborator

@sjrd sjrd commented Mar 18, 2024

Based on #19.

@sjrd sjrd requested a review from tanishiking March 18, 2024 16:05
Copy link
Owner

@tanishiking tanishiking left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at 5134e09 and 2129e14 LGTM!
It's great to see that now Scala.js has a hasDirectInstance 😍

sjrd added 2 commits March 18, 2024 17:55
Adjust for:

* `FieldName`s contain their declaring `className`.
* `StoreModule` does not store the enclosing class name nor the
  implicit `This` value anymore.
@sjrd sjrd marked this pull request as ready for review March 18, 2024 16:55
@sjrd
Copy link
Collaborator Author

sjrd commented Mar 18, 2024

It's great to see that now Scala.js has a hasDirectInstance 😍

I added it in scala-js/scala-js#4960 to support the Wasm backend. ;)

@sjrd sjrd merged commit f378cf4 into tanishiking:main Mar 18, 2024
1 check passed
@sjrd sjrd deleted the scalajs-1.16.0 branch March 18, 2024 16:57
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants