This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Basic support of reflective calls #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tanishiking
commented
Apr 10, 2024
Comment on lines
+736
to
+710
| // TODO: investigate what's going on | ||
| // Don't know why, but it seems that `this` isn't boxed even if | ||
| // t.receiver.tpe = ClassType(ClassName<java.lang.Boolean>), and | ||
| // primReceiverType = BooleanType | ||
| // This wired patch is required for `(func $f#java.lang.Boolean#compareTo_Ljava.lang.Boolean_R` |
There was a problem hiding this comment.
Without this change, validation fails because of the following wasm code
(func $f#java.lang.Boolean#compareTo_Ljava.lang.Boolean_R (type $f.268)
(param $___<this> i32) (param $that anyref) (result anyref)
local.get $___<this>
;; <this> is already unboxed
ref.as_non_null
call $__scalaJSHelpers#uZ
local.get $that
call $f#java.lang.Boolean#compareTo_Ljava.lang.Boolean_I
call $__scalaJSHelpers#bI)🤔
There was a problem hiding this comment.
Hum that's weird indeed. In the ClassDef of a hijacked class, the tpe of This() trees should always be the primitive. So here I would expect t.receiver.tpe == BooleanType, and therefore we should enter the first if (t.receiver.tpe == primReceiverType).
sjrd
reviewed
Apr 10, 2024
tanishiking
force-pushed
the
reflective-call
branch
2 times, most recently
from
c25f493 to
6b20614
Compare
Added a `reflectiveProxies` field to `typeData`, this field contains an array of struct with `methodId` of `i32`, and a reference to a reflective proxy function. When the compiler found an Apply to the reflective proxy, we lookup the method to call from the `reflectiveProxies` field in the receiver's `typeData` field, instead of normal table dispatching.
tanishiking
force-pushed
the
reflective-call
branch
from
6b20614 to
4549279
Compare
tanishiking
changed the title
sjrd
approved these changes
Apr 11, 2024
| @@ -47,6 +47,17 @@ object TypeTransformer { | |||
| case _ => List(transformType(t)) | |||
| } | |||
|
|
|||
| def transformTypeRef(t: IRTypes.TypeRef)(implicit ctx: ReadOnlyWasmContext): Types.WasmType = | |||
There was a problem hiding this comment.
This won't be correct for ClassRefs of JS types. We need to use
transformType(ctx.inferTypeFromTypeRef(typeRef))instead.
Note that this is not a problem in transformType because a ClassType(someJSType) is not valid in the first place. But ClassRef(someJSType) is valid; its corresponding type is AnyType.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#71
Added a
reflectiveProxiesfield totypeData, this field contains anarray of struct with
methodIdofi32, and a reference to areflective proxy function.
When the compiler found an Apply to the reflective proxy, we lookup the
method to call from the
reflectiveProxiesfield in the receiver'stypeDatafield, instead of normal table dispatching.TODO (maybe in another PR)
java.lang.Object#clone, it generates a following function, and it fails because a function$f#java.lang.Void#clone_Ljava.lang.Objectdoesn't exist.ReflectiveCallTest)