This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Fix static type tests for ancestors of hijacked classes. #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
fix-type-tests-for-ancestors-of-hijacked-classes
branch
from
5a02a15 to
71f17cd
Compare
tanishiking
approved these changes
Apr 12, 2024
| if (classInfo.isAncestorOfHijackedClass) { | ||
| /* It could be a hijacked class instance that implements this interface. | ||
| * Test whether `jsValueType(expr)` is in the `specialInstanceTypes` bitset. | ||
| * In other words, return `(1 << jsValueType(expr)) != 0`. |
There was a problem hiding this comment.
Suggested change
| * In other words, return `(1 << jsValueType(expr)) != 0`. | |
| * In other words, return `(1 << jsValueType(expr) & specialInstanceTypes) != 0`. |
| /* It could be a hijacked class instance that implements this interface. | ||
| * Test whether `jsValueType(expr)` is in the `specialInstanceTypes` bitset. | ||
| * In other words, return `(1 << jsValueType(expr)) != 0`. | ||
| */ |
There was a problem hiding this comment.
Though it might be a bit duplicated with an explanation at specialInstanceTypes, it would be helpful for me if we can add some example like below here 😅
Suggested change
| */ | |
| * | |
| * For example, when the `jsValueType(expr)` is 'string', 'expr.isInstanceOf[j.l.CharSequence]' | |
| * should be `true` because `j.l.String` implements `j.l.CharSequence`, and | |
| * `specialInstanceTypes` for `j.l.CharSequence` contains `1 << jsValueType(j.l.String)`. | |
| */ |
There was a problem hiding this comment.
I added a more concrete example. :)
This commit fixes the result of `x.isInstanceOf[C]` where `x` is a primitive and `C` is an ancestor of the hijacked class for `x`. For `jl.Number`, which is the only non-`Object` class that is an ancestor of a hijacked class, we add a special case in the codegen. For interfaces, we add generic code in their `genInstanceTest` function, based on their `specialInstanceTypes`. This means we have a second place where we need to compute `specialInstanceTypes`. We move it to the preprocessor, and also use it to generically compute `isAncestorOfHijackedClass`. This removes the hard-code set that we had before. Fix tanishiking#74. Fix tanishiking#84. Fix tanishiking#92.
sjrd
force-pushed
the
fix-type-tests-for-ancestors-of-hijacked-classes
branch
from
71f17cd to
716d7d4
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the result of
x.isInstanceOf[C]wherexis a primitive andCis an ancestor of the hijacked class forx.For
jl.Number, which is the only non-Objectclass that is an ancestor of a hijacked class, we add a special case in the codegen.For interfaces, we add generic code in their
genInstanceTestfunction, based on theirspecialInstanceTypes.This means we have a second place where we need to compute
specialInstanceTypes. We move it to the preprocessor, and also use it to generically computeisAncestorOfHijackedClass. This removes the hard-code set that we had before.Fix #74.
Fix #84.
Fix #92.