This repository was archived by the owner on Jul 12, 2024. It is now read-only.
Fix #76: Implement jl.Class.isInstance for JS classes. #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjrd
force-pushed
the
isinstance-for-js-classes
branch
from
e4b5f80 to
be00828
Compare
sjrd
force-pushed
the
isinstance-for-js-classes
branch
from
be00828 to
fd9f08a
Compare
sjrd
force-pushed
the
isinstance-for-js-classes
branch
from
fd9f08a to
33d23a9
Compare
tanishiking
approved these changes
Apr 13, 2024
| instrs += I32_CONST(0) | ||
| instrs += RETURN | ||
| } | ||
| instrs += LOCAL_SET(valueNonNullLocal) |
There was a problem hiding this comment.
[note]
In most cases, null check here isn't needed, and moved into the j.l.Object case + case _ =>, and we can reduce instructions in most scenaios
There was a problem hiding this comment.
That is true, though the most important thing is that if we need to throw the TypeError, we need to throw it even if the argument is null. So eagerly testing for null was not working.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.