Verkle/hive tests #56
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add network componenets for verkle sync Add verkle state to api and block processing
…ssing add whitespace changes
add the readOnlyNullVerkleStateStore
replace sstore costs with verkle
update test
There was a problem hiding this comment.
PR Overview
This PR introduces new tests and benchmark support for Verkle along with updates to configuration and API interfaces to enable Verkle-related features during block processing. Key changes include:
- Adding a new benchmark class for Verkle world state and updating the benchmark runner.
- Extending configuration and API interfaces with new Verkle-related properties.
- Updating various test and blockchain processing classes to support the Verkle features and to pass in required dependencies.
Reviewed Changes
| File | Description |
|---|---|
| src/Nethermind/Ethereum.Test.Base/IBlockchainTestBase.cs | Adds a new interface for blockchain tests with Setup() and RunTest(). |
| src/Nethermind/Nethermind.Benchmark/Verkle/VerkleWorldStateBenchmark.cs | Implements benchmarks for Verkle world state vs. MPT. |
| src/Nethermind/Nethermind.Api/IInitConfig.cs | Adds new config properties for stateless processing and Verkle proofs. |
| src/Nethermind/Nethermind.Api/InitConfig.cs | Implements the new configuration properties with default values. |
| src/Nethermind/Ethereum.Test.Base/JsonToEthereumTest.cs | Updates network string mappings for test specs. |
| src/Nethermind/Nethermind.Api/IApiWithBlockchain.cs | Adds properties for VerkleTreeStore and VerkleArchiveStore. |
| src/Nethermind/Nethermind.Api/NethermindApi.cs | Extends API with Verkle sync and storage properties. |
| src/Nethermind/Ethereum.Test.Base/BlockchainTestBase.cs | Changes to concrete implementation and method accessibility. |
| src/Nethermind/Ethereum.Test.Base/TestBlockJson.cs | Adds JSON mapping for ExecutionWitness using a custom converter. |
| src/Nethermind/Ethereum.Test.Base/LoadBlockchainTestsStrategy.cs | Updates test directory enumeration to use subdirectories. |
| src/Nethermind/Nethermind.Api/IApiWithNetwork.cs | Adds VerkleSyncServer property to network API interface. |
| src/Nethermind/Nethermind.Blockchain.Test/BlockProcessorTests.cs | Updates tests to inject IBlockTree dependency. |
| src/Nethermind/Nethermind.Blockchain.Test/FullPruning/FullPruningDiskTest.cs | Updates Build method signature to include genesisAllocation parameter. |
| src/Nethermind/Nethermind.AccountAbstraction.Test/AccountAbstractionRpcModuleTests.TestAccountAbstractionRpcBlockchain.cs | Updates Build method signature to include genesisAllocation. |
| src/Nethermind/Nethermind.Benchmark.Runner/Program.cs | Adds the Verkle benchmark assembly to the benchmark runner. |
| src/Nethermind/Nethermind.AccountAbstraction/Executor/AABlockProducerTransactionsExecutor.cs | Updates transaction processing to use executionTracer. |
| src/Nethermind/Nethermind.AuRa.Test/Contract/TxPriorityContractTests.cs | Updates Build method signature to include genesisAllocation. |
| src/Nethermind/Nethermind.AuRa.Test/AuraBlockProcessorTests.cs | Simplifies the constructor argument for WithdrawalProcessor. |
Copilot reviewed 454 out of 454 changed files in this pull request and generated 1 comment.
| [ConfigItem(Description = "If 'true' then the verkle proof in blocks are verified while block processing", DefaultValue = "false")] | ||
| bool VerifyProofsInBlock { get; set; } | ||
|
|
||
| [ConfigItem(Description = "If 'true' then the verkle proof in blocks are verified while block processing", DefaultValue = "false")] |
There was a problem hiding this comment.
The descriptions for 'VerifyProofsInBlock' and 'GenerateVerkleProofsForBlock' are identical, potentially causing confusion. Please update the description for one of these properties to accurately reflect its distinct functionality.
Suggested change
| [ConfigItem(Description = "If 'true' then the verkle proof in blocks are verified while block processing", DefaultValue = "false")] | |
| [ConfigItem(Description = "If 'true' then verkle proofs are generated for blocks during block processing", DefaultValue = "false")] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Closes Resolves #
Please choose one of the keywords above to refer to the issue this PR solves followed by the issue number (e.g. Fixes #000). If no issue number, remove the line. Also, remove everything marked optional that is not applicable. Remove this note after reading.
Changes
Types of changes
What types of changes does your code introduce?
Testing
Requires testing
If yes, did you write tests?
Notes on testing
Optional. Remove if not applicable.
Documentation
Requires documentation update
If yes, link the PR to the docs update or the issue with the details labeled
docs. Remove if not applicable.Requires explanation in Release Notes
If yes, fill in the details here. Remove if not applicable.
Remarks
Optional. Remove if not applicable.