Update decode.py

[samruddhisk]

New changes for pulling.

[samruddhisk]

I have raised a PR with mu code. Please check

[tanmoysrt]

Please check the content of PR.
It looks like all the code has been commented, and there is no update in codebase

[samruddhisk]

Please check the content of PR. It looks like all the code has been commented, and there is no update in codebase

I have uncommented the code. please check

[t-anjan]

Just a few comments from my quick review:

1. Useful comments have been removed.
2. "Verify email" and "Verify mobile" functions have been removed.
3. Aadhaar spelling has been wrongly changed, leading to many diffs.

Not sure why all these changes have been done.

[samruddhisk]

-- I have made changes only to AadhaarSecureQr class. the AadhaarOldQr and AadhaarOfflineXML classes are the same.
--For my requirement as of now verify email and verify mobile is not required, anyways we can add it, not an issue.
--Here priority is to get the data for both old and new Aaadhar QR codes. The same code is working on my local system. You can use my code functionality for reference while making changes to the existing decode.py file in main branch.(As the existing one is working only for old QR, not for new one).
--Aadhaar spelling in AadhaarSecureQr class is 'Aadhaar' as it was before. If there would be any spelling errors I would have got an error while running the code in my local too. However, this code gives me expected results for both old and new OR codes.

[t-anjan]

Can you please provide an example of a new QR which is NOT working with the existing code? And how do you differentiate between old and new QRs?

I have a QR generated in 2023, which is working with the existing code. Hence, I want to understand what is not working exactly.

[samruddhisk]

Sorry, but I can't share my QR code as it contains my personal information from Aadhaar. I recently downloaded my QR from maadhaar app, that is not working. It says 'string out of index'. My colleague had his QR code downloaded maybe last year, that is working fine.
I would suggest, you download your own new Aadhaar QR code from the app and try with it. As per my observation the field extractions from the new QR data is different than previous one.

[tanmoysrt]

-- I have made changes only to AadhaarSecureQr class. the AadhaarOldQr and AadhaarOfflineXML classes are the same. --For my requirement as of now verify email and verify mobile is not required, anyways we can add it, not an issue. --Here priority is to get the data for both old and new Aaadhar QR codes. The same code is working on my local system. You can use my code functionality for reference while making changes to the existing decode.py file in main branch.(As the existing one is working only for old QR, not for new one). --Aadhaar spelling in AadhaarSecureQr class is 'Aadhaar' as it was before. If there would be any spelling errors I would have got an error while running the code in my local too. However, this code gives me expected results for both old and new OR codes.

Please don't remove any functions, only do the changes that you need to modify.

[samruddhisk]

Sorry for the inconvenience. I have updated the code now.

[samruddhisk]

I have attached sample outputs for both old and new QR codes which I ran using my code. You can refer those.
You can find a difference in Decompressed array and Delimiters in both the files.

Sample output for new QR.txt
Sample output for old QR.txt

[t-anjan]

I have incorporated some of your changes into this PR: #22 .