Move consumer protocol types to sans-io crate #428
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change refactors the consumer protocol types (like MemberMetadata, MemberAssignment) from the broker crate into the sans-io crate. These are protocol-level types that belong with the other protocol serialization code. The sans-io crate now handles all encoding/decoding of the consumer protocol types independent of IO concerns.
4 tasks
The commit adds support for consumer groups including: - Client-side Group data structure - Range partition assignor implementation - Consumer protocol (de)serialization - Consumer group assignor trait and types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change refactors the consumer protocol types (like MemberMetadata, MemberAssignment) from the broker crate into the sans-io crate. These are protocol-level types that belong with the other protocol serialization code.
The sans-io crate now handles all encoding/decoding of the consumer protocol types independent of IO concerns.
note that this work is to facilitate a rust consumer group client and does not affect the operation of the existing broker consumer group functionality.