Skip to content

compaction, tombstones currently remaining zombies #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

compaction, tombstones currently remaining zombies #46

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
53 changes: 52 additions & 1 deletion tansu-storage/src/pg.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,27 @@ impl Storage for Postgres {
let tx = c.transaction().await?;

let prepared = tx
.prepare(concat!(
"select topic_configuration.value",
" from cluster, topic, topic_configuration",
" where",
" cluster.name = $1",
" and topic.name = $2",
" and topic_configuration.name = 'cleanup.policy'",
" and topic.cluster = cluster.id",
" and topic_configuration.topic = topic.id",
))
.await?;

let is_compact = tx
.query_opt(&prepared, &[&self.cluster.as_str(), &topition.topic()])
.await?
.map_or(false, |row| {
row.try_get::<_, String>(0)
.is_ok_and(|cleanup_policy| cleanup_policy == "compact")
});

let produce = tx
.prepare(concat!(
"insert into record",
" (topic, partition, producer_id, sequence, timestamp, k, v)",
Expand All @@ -362,9 +383,39 @@ impl Storage for Postgres {
for record in inflated.records {
debug!(?record);

if is_compact {
let compact = tx
.prepare(concat!(
"delete from record",
" using cluster, topic",
" where",
" cluster.name = $1",
" and topic.name = $2",
" and record.k = $3",
" and record.partition = $4",
" and topic.cluster = cluster.id",
" and record.topic = topic.id"
))
.await?;

let compacted = tx
.execute(
&compact,
&[
&self.cluster.as_str(),
&topition.topic(),
&record.key.as_deref(),
&topition.partition(),
],
)
.await?;

debug!(?compacted, ?record);
}

let row = tx
.query_one(
&prepared,
&produce,
&[
&topition.topic(),
&topition.partition(),
Expand Down