Skip to content

[infra] Simplify clang-tidy usage #379

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

uilianries
Copy link
Member

@uilianries uilianries commented Apr 12, 2025

This PR "improves" the current usage of Clang tidy in the CI:

  • First, it runs Cmake to obtain exported commands, which can be analyzed by clang-tidy
  • Similar to the first, clang-tidy is now running in parallel with xargs -P
  • Only errors from project headers are considered critical for failure
  • When failing it will mark as failed, but will not break the CI. Which means it is optional, not a blocker

@ColinH @d-frey We could have it as technical debt, what do you think?

@uilianries uilianries marked this pull request as ready for review April 12, 2025 12:22
@ColinH
Copy link
Member

ColinH commented Apr 12, 2025

Sounds good, with clang-tidy there's often that one check that you'd like to keep even if it has a false positive...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants