Skip to content

Support workspace #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 30, 2025
Merged

Support workspace #20

merged 3 commits into from
Mar 30, 2025

Conversation

taooceros
Copy link
Owner

@taooceros taooceros commented Mar 29, 2025

fix #19

@taooceros taooceros requested a review from Copilot March 29, 2025 17:52
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #19 by adding support for additional workspace types. The changes include renaming and type updates for workspace records, adjusting parsing logic to use the new WorkspaceLocation and WorkspaceType enums, and updating relevant usages throughout the codebase.

Reviewed Changes

Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
WorkspacesHelper/VSCodeWorkspacesApi.cs Renames VSCodeWorkspace to VsCodeWorkspace, updates parsing logic, and adds new helper methods for workspace entries.
WorkspacesHelper/VSCodeWorkspace.cs Updates the record and enums to use WorkspaceLocation and WorkspaceType in place of the previous naming.
WorkspacesHelper/ParseVSCodeUri.cs Adjusts tuple return types to use the new WorkspaceLocation enum.
SettingsView.xaml.cs Updates the usage of type checks based on WorkspaceLocation instead of the old TypeWorkspace.
Main.cs Changes the workspace record type and adjusts command-line argument selection based on the new WorkspaceType.
Files not reviewed (2)
  • Flow.Plugin.VSCodeWorkspaces.csproj: Language not supported
  • plugin.json: Language not supported
Comments suppressed due to low confidence (2)

WorkspacesHelper/VSCodeWorkspacesApi.cs:150

  • The property name 'Lable' appears to be a misspelling; consider renaming it to 'Label' for clarity and consistency.
workspace = workspace with { Lable = "${matchGroup.Groups[2]} ${matchGroup.Groups[1]}", WorkspaceType = WorkspaceType.Workspace };

Main.cs:41

  • The variable name 'defaultInstalce' seems to be misspelled; it likely should be 'defaultInstance'.
if (defaultInstalce != null)

@taooceros taooceros requested a review from Copilot March 29, 2025 19:22
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses issue #19 by updating the workspace support logic. Key changes include:

  • Renaming classes and properties (e.g. VSCodeWorkspace → VsCodeWorkspace, Lable → Label, TypeWorkspace → WorkspaceLocation) and adding the WorkspaceType enum.
  • Replacing the legacy _context variable with Context and updating related references.
  • Adjusting workspace parsing methods for both folder and workspace entries.

Reviewed Changes

Copilot reviewed 6 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
WorkspacesHelper/VSCodeWorkspacesApi.cs Renamed types and updated workspace parsing logic
WorkspacesHelper/VSCodeWorkspace.cs Renamed record and properties; introduced WorkspaceType enum
WorkspacesHelper/ParseVSCodeUri.cs Updated return tuple and enum usage
SettingsView.xaml.cs Updated enum comparisons per renaming
RemoteMachinesHelper/VSCodeRemoteMachinesApi.cs Updated logging call to reference Context instead of _context
Main.cs Replaced _context with Context and updated variable naming
Files not reviewed (2)
  • Flow.Plugin.VSCodeWorkspaces.csproj: Language not supported
  • plugin.json: Language not supported
Comments suppressed due to low confidence (1)

RemoteMachinesHelper/VSCodeRemoteMachinesApi.cs:63

  • The string interpolation syntax appears incorrect: use {vscode_settings} instead of ${vscode_settings} to properly embed the variable in the message.
var message = $"Failed to deserialize ${vscode_settings}";

@taooceros taooceros merged commit 8b13155 into main Mar 30, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Couldn't find workspaces
1 participant