Adjust virtual table's max ref table num.

[Simon9997]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello @Simon9997, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances the system's capacity to handle more complex virtual table definitions by doubling the maximum number of tables that a virtual table can reference. The associated test cases have been modified to validate this increased limit, ensuring the system behaves as expected under the new configuration.

Highlights

• Virtual Table Reference Limit: The maximum number of referenced tables allowed in a virtual table has been increased from 1000 to 2000.
• Test Case Adjustment: The test_vtable_max_column_num.py test case has been updated to reflect the new limit, specifically by reducing the number of tables created in the setup and adjusting the modulo operator for column creation from 1001 to 2001.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request increases the maximum number of referenced tables in a virtual table from 1000 to 2000 and updates the corresponding tests. The changes are correct, but I've suggested replacing the magic numbers with named constants in both the application code and the test code to improve readability and maintainability.

[Copilot]

Pull request overview

This PR increases the maximum number of reference tables allowed in virtual tables from 1000 to 2000. The change updates both the core implementation and corresponding test cases to validate the new limit.

Changes:

• Increased the reference table limit check from 1000 to 2000 in the C code
• Optimized test setup by reducing table creation from 32767 to 3000 (sufficient for testing)
• Updated error case tests to reference 2001 tables (using modulo 2001), which correctly exceeds the new limit of 2000

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File	Description
source/dnode/vnode/src/meta/metaTable.c	Increased the hash size check from 1000 to 2000 reference tables; removed unnecessary blank lines
test/cases/05-VirtualTables/test_vtable_max_column_num.py	Reduced test table creation from 32767 to 3000 for efficiency; updated modulo from 1001 to 2001 to correctly test the new 2000 limit

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.