Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request updates the Python connector documentation to reflect recent enhancements in authentication mechanisms. It introduces new versions of both the Python and WebSocket connectors that support token-based authentication for data subscriptions and clarifies the usage and priority of different authentication tokens for database connections. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Pull request overview
Updates the Python connector documentation to reflect newly added token-auth support for data subscription and introduces/clarifies related authentication configuration fields.
Changes:
- Add version-history entries for
taospy 2.8.9andtaos-ws-py 0.6.6noting token-auth support for data subscription. - Update TMQ consumer configuration docs to distinguish cloud-token vs database-token authentication (including introducing
td.connect.bearer_tokenin one section).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
| docs/zh/14-reference/05-connector/30-python.mdx | Adds new version-history rows and updates TMQ consumer auth property descriptions (token/bearer_token). |
| docs/en/14-reference/05-connector/30-python.md | Adds new version-history rows and updates TMQ consumer auth property descriptions (token/bearer_token); includes a small connector-name typo near the updated version section. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the Python connector documentation to include recent changes, such as support for token authentication in data subscriptions. The changes look good overall, but I've pointed out a potential point of confusion in both the English and Chinese documents regarding the td.connect.token parameter, which appears to have different meanings for WebSocket and Native connections. Clarifying this would improve the documentation's usability.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated 4 comments.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This reverts commit 1444fd0.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 13 out of 14 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (2)
docs/en/14-reference/05-connector/30-python.md:289
- In the new
__next__return-value description, there appear to be stray/invisible characters between "values" and "of" (renders as "values of" or similar). Please replace with a normal single space to avoid odd rendering/searchability in the published docs.
- **Parameter Description**:
docs/en/14-reference/05-connector/30-python.md:509
- Same issue here: the return-value description contains stray/invisible characters between "values" and "of". Please replace them with a normal single space.
- `precision`: Time precision
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Description
docs: update python docs
Issue(s)
Checklist
Please check the items in the checklist if applicable.