fix: [6880760974] Open window cases.

[Simon9997]

Description

Issue(s)

• Close/close/Fix/fix/Resolve/resolve: Issue Link

Checklist

Please check the items in the checklist if applicable.

• Is the user manual updated?
• Are the test cases passed and automated?
• Is there no significant decrease in test coverage?

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly expands the test coverage for virtual tables by activating a large set of existing test cases in the CI pipeline. The change ensures that a wider range of virtual table functionalities, from basic operations to complex query scenarios, are regularly validated, thereby improving the overall stability and reliability of the virtual table feature.

Highlights

• CI Test Case Expansion: Enabled a comprehensive suite of 43 new test cases related to Virtual Tables within the test/ci/win_cases.task configuration file. These cases cover various aspects of virtual table functionality, including alteration, authorization, creation, dropping, insertion, joining, metadata, query planning, and diverse query scenarios across different database and table types.
• Virtual Table Testing: The newly activated tests specifically target the 05-VirtualTables directory, ensuring broader coverage and validation of virtual table operations and behaviors in the continuous integration pipeline.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog

• test/ci/win_cases.task
  • Added 43 new test cases for virtual tables to be run in the CI pipeline.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[Copilot]

Pull request overview

This PR aims to “open” (enable) additional Windows CI test cases by adding a large set of VirtualTables pytest cases into a Windows task list.

Changes:

• Added many cases/05-VirtualTables/*.py pytest entries to test/ci/win_cases.task.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[Copilot]

These VirtualTables cases are already listed in test/ci/cases.task (which is what the Windows pipeline actually runs via python3 ci\\run_win_cases.py ci\\cases.task). Updating test/ci/win_cases.task appears to have no effect and adds a second, diverging source of truth. Consider either (1) switching the pipeline to use win_cases.task, or (2) removing/avoiding win_cases.task and updating cases.task instead (or documenting why both files exist).

[gemini-code-assist]

Code Review

This pull request enables a large suite of virtual table test cases for the Windows CI build by adding them to win_cases.task. My review focuses on the maintainability of this list. I've suggested sorting the newly added test cases alphabetically to make the file easier to manage and to prevent accidental duplicates in the future.

[gemini-code-assist]

For better maintainability and to avoid potential duplicates, it's a good practice to keep this list of test cases sorted alphabetically by file path.

,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_alter.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_auth_alter_normaltable.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_auth_alter_subtable.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_auth_create.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_auth_select.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_create.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_drop.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_insert.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_join.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_max_column_num.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_meta.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_plan_eliminate_virtual_scan.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_plan_pushdown_timerange.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_plan_replace_tbname.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_after_alter.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_after_alter_origin_table.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_after_drop_origin_table.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_cross_db_ctb.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_cross_db_ntb.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_cross_db_stb_agg.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_cross_db_stb_agg_sma.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_cross_db_stb_function.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_cross_db_stb_group.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_cross_db_stb_project.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_cross_db_stb_window.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_cross_db_stb_window_state.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_eliminate_virtual_scan.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_plan.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_ctb.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_ctb_window_state.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_ntb.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_ntb_window_state.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_stb_agg.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_stb_agg_sma.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_stb_group.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_stb_project.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_stb_window.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_db_stb_window_state.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_same_reference_col.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_query_with_null_value.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_schema_is_old.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_show_create.py
,,y,.,./ci/pytest.sh pytest cases/05-VirtualTables/test_vtable_show_tag.py