-
Notifications
You must be signed in to change notification settings - Fork 6
docs: Specify minimum Docker memory requirement #288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Add memory requirement for Docker installation.
Summary of ChangesHello @tomchon, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the Docker installation documentation by introducing a critical memory requirement. The change aims to prevent potential installation or operational issues for users by clearly outlining the necessary Docker memory allocation, thereby improving the overall clarity and robustness of the setup guide. Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds an important minimum memory requirement for Docker installations to the documentation. The change is a good addition. My review focuses on ensuring the documentation is consistent and clear across different language versions. I've identified that the corresponding English documentation is missing this update, and there are other inconsistencies in the prerequisites section, such as list numbering and a missing 'Git' requirement compared to the English version. Addressing these points will improve the quality and consistency of the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This pull request adds a minimum Docker memory requirement specification to the Docker installation guide documentation. The change ensures users are aware of the memory prerequisites before attempting to deploy TDengine TSDB-Enterprise and TDengine IDMP services using Docker.
Changes:
- Added a new prerequisite line specifying that Docker requires at least 10GB of memory
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
|
||
| 1. 本文适用 Docker 20.10 以上版本 | ||
| 1. 本文适用 Docker Compose v1.29.2 以上版本 | ||
| 1. 所需 Docker 内存大于等于 10GB |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There appears to be trailing whitespace at the end of this line. Remove the trailing space after "10GB" for consistency with documentation formatting standards.
| 1. 所需 Docker 内存大于等于 10GB | |
| 1. 所需 Docker 内存大于等于 10GB |
Add memory requirement for Docker installation.