Skip to content

enh: separate locales again#368

Draft
danielclow wants to merge 1 commit intomainfrom
enh/separate-locales-again
Draft

enh: separate locales again#368
danielclow wants to merge 1 commit intomainfrom
enh/separate-locales-again

Conversation

@danielclow
Copy link
Collaborator

same as the last one

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request re-establishes the separation of locale-specific builds and deployments for the documentation site. It configures the Docusaurus project to generate distinct output directories for English and Chinese content, enabling each language version to be deployed to its own unique domain. This change streamlines the management and hosting of multilingual documentation.

Highlights

  • Build Output Separation: The build process was updated to generate separate output directories for English ("build-en") and Chinese ("build") locales, and these new directories were added to .gitignore.
  • Locale-Specific Configuration: The Docusaurus configuration now includes distinct baseUrl and url settings for the English and Chinese locales, allowing them to be hosted on different domains.
  • Enhanced Build and Serve Scripts: New npm scripts (build-zh, build-en, serve-en) were introduced in package.json to facilitate building and serving specific locales independently.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • .gitignore
    • Added /build-zh.
    • Added /build-en.
  • docusaurus.config.js
    • Removed blank lines in customSidebarItemsGenerator.
    • Configured baseUrl and url for the 'en' locale.
    • Configured htmlLang, baseUrl, and url for the 'zh-Hans' locale.
  • package.json
    • Modified the build script to build both zh-Hans and en locales, with en outputting to build-en.
    • Added build-zh script.
    • Added build-en script.
    • Added serve-en script.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to separate the build configurations for different locales, which is a good enhancement. The changes to .gitignore and docusaurus.config.js are correct. However, I found a bug in the package.json scripts where running a locale-specific build could overwrite another locale's build artifacts. I've provided a review comment with a suggested fix that not only resolves the bug but also improves the overall consistency and clarity of the build scripts.

Copy link
Contributor

@wingwing2005 wingwing2005 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants