Skip to content

fix: TAP-5941 doris create table failed with default value #495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarad0628 merged 2 commits into from
Mar 16, 2025
Merged

fix: TAP-5941 doris create table failed with default value #495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
349c18c
fix: TAP-5941 doris create table failed with default value
mnianqi Mar 12, 2025
c9d8fa2
fix: TAP-5941 doris create table failed with default value
mnianqi Mar 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion connectors-common/mysql-core/src/main/java/io/tapdata/connector/mysql/MysqlMaker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -322,7 +322,7 @@ protected String createTableAppendField(TapField tapField) {
} else {
builder.append("'").append(StringKit.escape(tapField.getDefaultValue().toString(), "'")).append("' ");
}
fieldSql += builder.toString();
fieldSql += " " + builder;
}

// comment
Expand Down
1 change: 1 addition & 0 deletions connectors/doris-connector/src/main/java/io/tapdata/connector/doris/DorisConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,6 +72,7 @@ public void onStart(TapConnectionContext tapConnectionContext) {
if (tapConnectionContext instanceof TapConnectorContext) {
ddlSqlGenerator = new DorisDDLSqlGenerator();
}
tapLogger = tapConnectionContext.getLog();
commonDbConfig = dorisConfig;
jdbcContext = dorisJdbcContext;
commonSqlMaker = new DorisSqlMaker();
Expand Down
2 changes: 1 addition & 1 deletion connectors/doris-connector/src/main/java/io/tapdata/connector/doris/DorisSqlMaker.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ public String buildColumnDefinitionByOrder(TapTable tapTable, Collection<String>
if (aggregate && Boolean.FALSE.equals(tapField.getPrimaryKey())) {
builder.append("REPLACE_IF_NOT_NULL ");
}
buildDefaultDefinition(builder, tapField);
buildNullDefinition(builder, tapField);
buildDefaultDefinition(builder, tapField);
buildCommentDefinition(builder, tapField);
return builder.toString();
}).collect(Collectors.joining(", "));
Expand Down
Loading