Skip to content

TAP-6443：fix mysql no pk AUTO_INCREMENT filed no sync #509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jarad0628 merged 1 commit into from
Apr 27, 2025
Merged

TAP-6443：fix mysql no pk AUTO_INCREMENT filed no sync #509

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions connectors-common/sql-core/src/main/java/io/tapdata/common/CommonDbConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,18 @@ protected void createIndex(TapConnectorContext connectorContext, TapTable tapTab
}
}
});
List<String> afterUniqueAutoIncrementSql =getAfterUniqueAutoIncrementFields(tapTable, indexList);
if(EmptyKit.isNotEmpty(afterUniqueAutoIncrementSql)){
afterUniqueAutoIncrementSql.forEach(sql -> {
try {
jdbcContext.execute(sql);
} catch (SQLException e) {
tapLogger.warn("Failed to update auto-increment column {}, please execute it manually [{}]", e.getMessage(), sql);
}
});
}
}

}

protected void createConstraint(TapConnectorContext connectorContext, TapTable tapTable, TapCreateConstraintEvent createConstraintEvent, boolean create) {
Expand Down Expand Up @@ -964,4 +975,8 @@ protected long countByAdvanceFilterV2(TapConnectorContext connectorContext, TapT
});
return count.get();
}
protected List<String> getAfterUniqueAutoIncrementFields(TapTable tapTable,List<TapIndex> indexList) {
return new ArrayList<>();
}

}
20 changes: 20 additions & 0 deletions connectors/mysql-connector/src/main/java/io/tapdata/connector/mysql/MysqlConnector.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,7 @@
import io.tapdata.pdk.apis.partition.TapPartitionFilter;
import io.tapdata.pdk.apis.partition.splitter.StringCaseInsensitiveSplitter;
import io.tapdata.pdk.apis.partition.splitter.TypeSplitterMap;
import io.tapdata.entity.schema.TapIndexField;

import java.sql.*;
import java.time.LocalDateTime;
Expand Down Expand Up @@ -995,4 +996,23 @@ protected void createConstraint(TapConnectorContext connectorContext, TapTable t
}
}

protected List<String> getAfterUniqueAutoIncrementFields(TapTable tapTable,List<TapIndex> indexList) {
if(!mysqlConfig.getCreateAutoInc())return new ArrayList<>();
String sql = "ALTER TABLE `%s` MODIFY COLUMN `%s` %s AUTO_INCREMENT";
List<String> uniqueFields = new ArrayList<>();
List<String> uniqueAutoIncrementFields = new ArrayList<>();
indexList.forEach(index -> {
if(index.isUnique()){
uniqueFields.addAll(index.getIndexFields().stream().map(TapIndexField::getName).collect(Collectors.toList()));
}
});
tapTable.getNameFieldMap().values().forEach(f -> {
if(f.getAutoInc() && !f.getPrimaryKey() && uniqueFields.contains(f.getName())){
uniqueAutoIncrementFields.add(f.getName());
}
});

return uniqueAutoIncrementFields.stream().map(f -> String.format(sql, tapTable.getId(), f, tapTable.getNameFieldMap().get(f).getDataType())).collect(Collectors.toList());
}

}
Loading