test: install crud from master #403
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently `make deps`, which is used for tests, installs specified version of `crud`. Such approach complicates integration with Tarantool: when a patch in Tarantool breaks integration with both `crud` and `go-tarantool` (because it uses `crud`), one needs to fix `crud`, then release it and then bump it to the new version in makefile of `go-tarantool`. Let's simplify this process - simply install `crud` from its master for tests. Note that such approach has a drawback - any commit in `crud` can break integration with `go-tarantool`.
drewdzzz
force-pushed
the
install_crud_master
branch
2 times, most recently
from
491289b to
d8af645
Compare
Since GitHub does not support `macos-11` runners anymore, jobs using these runners just hang. Let's replace them with the most actual `macos-14` runners. Now we test the project against 12 and 14 versions: we could fill the gap, but let's not create new runners without actual need. Tarantool 1.10 fails to build on `macos-14` runner, so this combination is excluded from testing matrix. Closes #402
drewdzzz
force-pushed
the
install_crud_master
branch
2 times, most recently
from
a8e6c18 to
a539a86
Compare
oleg-jukovec
approved these changes
Aug 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
make deps, which is used for tests, installs specified version ofcrud. Such approach complicates integration with Tarantool: when a patch in Tarantool breaks integration with bothcrudandgo-tarantool(because it usescrud), one needs to fixcrud, then release it and then bump it to the new version in makefile ofgo-tarantool. Let's simplify this process - simply installcrudfrom its master for tests. Note that such approach has a drawback - any commit incrudcan break integration withgo-tarantool.The patch is intended to fix failing integration test in
tarantool.Along the way, the patch drops
macOS-11runners since they are not supported by GitHub anymore.