Add replicaset name to metrics #70
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KaymeKaydex
force-pushed
the
metrics/replicaset-name
branch
from
4944146 to
c1a57cb
Compare
KaymeKaydex
force-pushed
the
metrics/replicaset-name
branch
from
c1a57cb to
b603439
Compare
nurzhan-saktaganov
suggested changes
Apr 16, 2025
| @@ -281,7 +281,7 @@ func (r *Router) Call(ctx context.Context, bucketID uint64, mode CallMode, | |||
|
|
|||
| for { | |||
| if spent := time.Since(requestStartTime); spent > timeout { | |||
| r.metrics().RequestDuration(spent, fnc, false, false) | |||
| r.metrics().RequestDuration(spent, fnc, "", false, false) | |||
There was a problem hiding this comment.
We discussed privately that every request to any replicaset should generate a metric. So, I suggest these fixes to the current PR: #72
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has been done? Why? What problem is being solved?
No we support replicaset name and can watch on replicaset metrics
I didn't forget about (remove if it is not applicable):
Related issues: