Skip to content

ci: bump ubuntu version #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 18, 2025

Conversation

patapenka-alexey
Copy link
Contributor

@patapenka-alexey patapenka-alexey commented Apr 3, 2025

Bump actions to use ubuntu-24.04 for fixing the following GitHub
warning:

The Ubuntu 20.04 Actions runner image will begin deprecation
on 2025-02-01.

This commit adds CMake policy to prevent warnings from
old third_party dependencies, bumps libmemcached third_party library
to support build on Ubuntu 24.04.

Part of #TNTP-1918
Closes #115

@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch 6 times, most recently from c4cdc3c to a28fb18 Compare April 9, 2025 11:18
Comment on lines 54 to 58
# https://github.com/tarantool/memcached/issues/115
# - run: make test-memcached-capable

- name: Run benchmarks
run: make test-memcached-bench
# https://github.com/tarantool/memcached/issues/90
# - name: Run benchmarks
# run: make test-memcached-bench

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you delete it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cause it doesn't work by the same reason as test-memcached-capable.

@oleg-jukovec oleg-jukovec self-requested a review April 9, 2025 12:16
@patapenka-alexey patapenka-alexey marked this pull request as ready for review April 10, 2025 08:09
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch 3 times, most recently from a31ba0a to 3487ce4 Compare April 17, 2025 12:49
@patapenka-alexey patapenka-alexey requested review from elhimov and oleg-jukovec and removed request for oleg-jukovec April 17, 2025 12:56
Copy link

@elhimov elhimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but consider using -y option with apt install

Bump actions to use ubuntu-24.04 for fixing the following GitHub
warning:

    The Ubuntu 20.04 Actions runner image will begin deprecation
    on 2025-02-01.

This commit adds CMake policy to prevent warnings from
old third_party dependencies, bumps libmemcached third_party library
to support build on Ubuntu 24.04.

Part of #TNTP-1918
Closes #115
@patapenka-alexey patapenka-alexey force-pushed the patapenka-alexey/tntp-1918-bump-ubuntu-version branch from 3487ce4 to bc36ccf Compare April 18, 2025 04:53
@oleg-jukovec oleg-jukovec merged commit be209be into master Apr 18, 2025
17 checks passed
@oleg-jukovec oleg-jukovec deleted the patapenka-alexey/tntp-1918-bump-ubuntu-version branch April 18, 2025 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

libmemcached doesn't build on Ubuntu 22.04.1 LTS
3 participants