Merged
Conversation
themilchenko
force-pushed
the
themilchenko/gh-22-add-coverage-job
branch
from
77b5bb5 to
21c4fa1
Compare
| runs: | ||
| using: "composite" | ||
| steps: | ||
| - name: Install tarantool ${{ inputs.tarantool }} |
Member
There was a problem hiding this comment.
Suggested change
| - name: Install tarantool ${{ inputs.tarantool }} | |
| - name: Install tarantool ${{ inputs.tarantool }} (dymanic) |
| make | ||
| make DESTDIR=${TNT_DEBUG_PATH} install | ||
|
|
||
| - name: Install tarantool ${{ inputs.tarantool }} |
Member
There was a problem hiding this comment.
Suggested change
| - name: Install tarantool ${{ inputs.tarantool }} | |
| - name: Install tarantool ${{ inputs.tarantool }} (debug) |
It's more convenient to have a separate action that installs the necessary Tarantool. After the patch the code that installs Tarantool was moved to a separate action.
Running tests, collecting the coverage and sending it to the coveralls was in a single job. After the patch tests, whether ran with and without coverage, were separated. Closes #22
themilchenko
force-pushed
the
themilchenko/gh-22-add-coverage-job
branch
3 times, most recently
from
b977a62 to
a9d021a
Compare
Added to the test matrix Tarantool 3.3.1 version with the lowest supported version with wich role is working.
Since the installation of rocks takes not much time, so its caching can be removed.
themilchenko
force-pushed
the
themilchenko/gh-22-add-coverage-job
branch
from
a9d021a to
a2a8ea0
Compare
|
Couldn't last two commits be squashed with the |
Contributor
Author
I think there are two logical commits: first one extends test matrix and the second one deletes rocks caching in two jobs. As for me, non of these last commits can be related to a |
DerekBum
approved these changes
Jan 13, 2025
DifferentialOrange
approved these changes
Jan 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Running tests, collecting the coverage and sending it to the coveralls was in a single job. After the patch tests, whether ran with and without coverage, were separated.
Closes #22