feat: upgrade to Go 1.25 and Kubernetes client-go v0.35.0#102
Open
eddiebarth1 wants to merge 4 commits intotarget:masterfrom
Open
feat: upgrade to Go 1.25 and Kubernetes client-go v0.35.0#102eddiebarth1 wants to merge 4 commits intotarget:masterfrom
eddiebarth1 wants to merge 4 commits intotarget:masterfrom
Conversation
- Update Go version from 1.13 to 1.22.0 - Upgrade k8s.io/api, apimachinery, client-go from v0.17 to v0.31.4 - Migrate from policy/v1beta1 to policy/v1 for Eviction API - Update client-go calls to use context.TODO() (required in newer API) - Update joonix/log to use NewFormatter() API 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
- Add edge case tests for all 6 rules (chaos, container_status, duration, unready, pod_status, pod_status_phase) covering boundary conditions, whitespace handling, case sensitivity, and special values - Add comprehensive reaper package tests using k8s fake client for getPods(), reapPod(), scytheCycle(), and harvest() - Change clientSet type from *kubernetes.Clientset to kubernetes.Interface to enable testing with fake client - Fix bug in getPods() where error was checked after using podList - Remove redundant panic() calls after logrus.Panic() - Add defensive check in unready rule for zero-value LastTransitionTime Test coverage improved: - Rules package: 97% -> 100% - Reaper package: 62% -> 86.5% - Overall: 72.6% -> ~90% Co-authored-by: Eduardo Barth <ebarth@medium.com> Co-authored-by: Claude Opus 4.5 <noreply@anthropic.com>
- Update Go version from 1.22 to 1.25 - Update k8s.io/api, apimachinery, client-go from v0.31.4 to v0.35.0 - Remove deprecated rand.Seed() from rules/chaos.go (Go 1.22+ auto-seeds) - Refactor options_test.go random sort test to avoid deprecated rand.Seed() - Update all indirect dependencies via go mod tidy Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rand.Seed()calls (Go 1.22+ auto-seeds the global random source)Changes
rand.Seed()init functionCompatibility
Test plan
go build ./...compiles successfullygo vet ./...passesgo test ./...all tests pass🤖 Generated with Claude Code