feat(minotari): Wallet deletion

[igordanilcenko]

No description provided.

[gemini-code-assist]

Summary of Changes

Hello @igordanilcenko, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces the essential functionality for deleting Minotari wallets, ensuring a complete removal of wallet data from both the application's local storage and its associated database. This enhancement provides users with better control over their wallet management.

Highlights

• Wallet Deletion Implementation: Implemented the remove method within MinotariWalletService to provide comprehensive wallet deletion capabilities.
• Rust FFI Integration: Integrated a new Rust FFI function, deleteWallet, to facilitate the removal of wallet data directly from the underlying database.
• Enhanced Deletion Logic: Added robust error handling and verbose logging for both database and file system deletion processes, improving reliability and traceability.

Changelog

• cw_minotari/lib/minotari_wallet_service.dart
  • Added imports for verbose printing utilities and the deleteWallet Rust FFI function.
  • Modified the remove method to include a try-catch block for calling the deleteWallet FFI, ensuring database cleanup.
  • Enhanced the remove method with verbose logging for successful and failed database deletions, as well as for directory and wallet info deletions.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request implements the wallet deletion functionality for Minotari wallets. The changes include importing necessary utilities and FFI functions, and updating the remove method in MinotariWalletService to first attempt deleting the wallet from the Rust database, then removing local files and wallet information. The logging has been improved to provide more verbose output during the deletion process. The review comment highlights a potential issue with error handling during wallet deletion, suggesting that exceptions should be rethrown to prevent inconsistent states, which is a valid concern not covered by the provided rules.