chore: prepare easier crates releases#7679
chore: prepare easier crates releases#7679SWvheerden wants to merge 2 commits intotari-project:developmentfrom
Conversation
Summary of ChangesHello @SWvheerden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on preparing the project for easier and more consistent releases to crates.io. It achieves this by standardizing dependency versions across the workspace, enriching the metadata of various crates with essential information like descriptions and repository links, and streamlining internal dependencies to simplify the overall release process. Highlights
Changelog
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request prepares the crates for easier releases on crates.io. The changes include adding metadata like descriptions and repository links to Cargo.toml files, unifying crate versions using workspace inheritance, and refactoring to remove a dependency from tari_test_utils on tari_comms. Overall, the changes are straightforward and align with the goal of preparing for a release. I've found one issue regarding an inconsistent version in Cargo.lock that should be addressed.
| [[package]] | ||
| name = "minotari_wallet_grpc_client" | ||
| version = "0.1.0" | ||
| version = "5.2.1" |
There was a problem hiding this comment.
There appears to be a version mismatch for the minotari_wallet_grpc_client crate. The Cargo.toml for this crate sets version.workspace = true, and the workspace version is defined as 5.3.0-pre.0. However, this Cargo.lock file specifies version 5.2.1.
This inconsistency could lead to using an outdated version of the crate. Please run cargo update to ensure the Cargo.lock file is consistent with the workspace versions.
|
replaced by #7690 |
Description
makes a few changes to do easier crates.io releases