Skip to content

chore: prepare easier crates releases#7679

Closed
SWvheerden wants to merge 2 commits intotari-project:developmentfrom
SWvheerden:sw_releases
Closed

chore: prepare easier crates releases#7679
SWvheerden wants to merge 2 commits intotari-project:developmentfrom
SWvheerden:sw_releases

Conversation

@SWvheerden
Copy link
Collaborator

Description

makes a few changes to do easier crates.io releases

@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @SWvheerden, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on preparing the project for easier and more consistent releases to crates.io. It achieves this by standardizing dependency versions across the workspace, enriching the metadata of various crates with essential information like descriptions and repository links, and streamlining internal dependencies to simplify the overall release process.

Highlights

  • Dependency Version Standardization: Standardized versions for all workspace dependencies in Cargo.toml to 5.3.0-pre.0 and updated individual crate Cargo.toml files to use version.workspace = true.
  • Crates.io Metadata Enrichment: Added description, repository, and license fields to several Cargo.toml files to improve readiness for publication on crates.io.
  • Dependency Refactoring: Refactored the get_next_memory_address utility in base_layer/wallet/tests/transaction_service_tests/service.rs to reduce reliance on tari_test_utils and removed the tari_comms dependency from infrastructure/test_utils.
Changelog
  • Cargo.lock
    • Updated the version of minotari_wallet_grpc_client to 5.2.1.
    • Removed the tari_comms dependency from tari_test_utils.
  • Cargo.toml
    • Added the 'common' directory to the workspace members list.
    • Standardized the version for all workspace dependencies to 5.3.0-pre.0.
  • applications/minotari_ledger_wallet/common/Cargo.toml
    • Added a description for the minotari_ledger_wallet_common package.
  • applications/minotari_ledger_wallet/comms/Cargo.toml
    • Added a description for the minotari_ledger_wallet_comms package.
    • Configured the repository field to use the workspace setting.
  • base_layer/sidechain/Cargo.toml
    • Added a description for the tari_sidechain package.
    • Configured the repository and license fields to use workspace settings.
  • base_layer/wallet/tests/transaction_service_tests/service.rs
    • Imported Multiaddr and MemoryTransport from tari_comms.
    • Removed the import of get_next_memory_address from tari_test_utils.
    • Re-implemented the get_next_memory_address function locally within the file.
  • clients/rust/base_node_wallet_client/Cargo.toml
    • Added a description for the minotari_node_wallet_client package.
  • clients/rust/wallet_grpc_client/Cargo.toml
    • Changed the package version to use the workspace version.
  • infrastructure/jellyfish/Cargo.toml
    • Added a description for the tari_jellyfish package.
    • Configured the repository and license fields to use workspace settings.
  • infrastructure/max_size/Cargo.toml
    • Enabled the derive feature for the borsh dependency.
  • infrastructure/test_utils/Cargo.toml
    • Configured the repository field to use the workspace setting.
    • Removed the tari_comms dependency.
  • infrastructure/test_utils/src/lib.rs
    • Removed the comms_and_services module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request prepares the crates for easier releases on crates.io. The changes include adding metadata like descriptions and repository links to Cargo.toml files, unifying crate versions using workspace inheritance, and refactoring to remove a dependency from tari_test_utils on tari_comms. Overall, the changes are straightforward and align with the goal of preparing for a release. I've found one issue regarding an inconsistent version in Cargo.lock that should be addressed.

[[package]]
name = "minotari_wallet_grpc_client"
version = "0.1.0"
version = "5.2.1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

There appears to be a version mismatch for the minotari_wallet_grpc_client crate. The Cargo.toml for this crate sets version.workspace = true, and the workspace version is defined as 5.3.0-pre.0. However, this Cargo.lock file specifies version 5.2.1.

This inconsistency could lead to using an outdated version of the crate. Please run cargo update to ensure the Cargo.lock file is consistent with the workspace versions.

@SWvheerden
Copy link
Collaborator Author

replaced by #7690

@SWvheerden SWvheerden closed this Mar 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant