fix: skip pool stats fetching when pool mining is disabled#3166
Open
brianp wants to merge 1 commit intotari-project:mainfrom
Open
fix: skip pool stats fetching when pool mining is disabled#3166brianp wants to merge 1 commit intotari-project:mainfrom
brianp wants to merge 1 commit intotari-project:mainfrom
Conversation
Contributor
|
Warning Gemini is experiencing higher than usual traffic and was unable to create the summary. Please try again in a few hours by commenting |
8ae73aa to
b9f9fb7
Compare
b9f9fb7 to
0f117f8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Pool API requests were firing during wallet init even when the user had pools turned off. The
handle_wallet_address_changecalls on bothCpuPoolManagerandGpuPoolManagerran unconditionally, hitting the pool API over HTTP every time the wallet initialized.Now we check
cpu_pool_enabled/gpu_pool_enabledbefore calling those handlers.Motivation and Context
Unnecessary HTTP requests to pool APIs when pools are off. Wasted bandwidth and log noise for solo miners.
Closes #3165
How Has This Been Tested?
Requesting ... pool status from:log lines during wallet initWhat process can a PR reviewer use to test or verify this change?
cpu_pool_enabledandgpu_pool_enabledtofalsein pool configBreaking Changes