Skip to content

fix: skip pool stats fetching when pool mining is disabled#3166

Open
brianp wants to merge 1 commit intotari-project:mainfrom
brianp:fix/skip-pool-stats-when-disabled
Open

fix: skip pool stats fetching when pool mining is disabled#3166
brianp wants to merge 1 commit intotari-project:mainfrom
brianp:fix/skip-pool-stats-when-disabled

Conversation

@brianp
Copy link
Collaborator

@brianp brianp commented Mar 6, 2026

Description

Pool API requests were firing during wallet init even when the user had pools turned off. The handle_wallet_address_change calls on both CpuPoolManager and GpuPoolManager ran unconditionally, hitting the pool API over HTTP every time the wallet initialized.

Now we check cpu_pool_enabled / gpu_pool_enabled before calling those handlers.

Motivation and Context

Unnecessary HTTP requests to pool APIs when pools are off. Wasted bandwidth and log noise for solo miners.

Closes #3165

How Has This Been Tested?

  • Disabled pool mining, restarted app, confirmed no Requesting ... pool status from: log lines during wallet init
  • Enabled pool mining, confirmed pool status requests still fire normally

What process can a PR reviewer use to test or verify this change?

  1. Set cpu_pool_enabled and gpu_pool_enabled to false in pool config
  2. Start the app and watch logs for pool status request lines
  3. They shouldn't appear during wallet initialization
  4. Toggle pools back on, restart, confirm they show up again

Breaking Changes

  • None
  • Requires data directory on base node to be deleted
  • Requires hard fork
  • Other - Please specify

@gemini-code-assist
Copy link
Contributor

Warning

Gemini is experiencing higher than usual traffic and was unable to create the summary. Please try again in a few hours by commenting /gemini summary.

@brianp brianp force-pushed the fix/skip-pool-stats-when-disabled branch from 8ae73aa to b9f9fb7 Compare March 6, 2026 15:29
@brianp brianp force-pushed the fix/skip-pool-stats-when-disabled branch from b9f9fb7 to 0f117f8 Compare March 6, 2026 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Pool stats are fetched even when pool mining is disabled

1 participant