fix: Mitigate risks due to "next" known CVEs (Signed)#136
Conversation
|
If you're new to commit signing, there are different ways to set it up: Sign commits with
|
There was a problem hiding this comment.
Code Review
This pull request downgrades the next dependency to 14.1.1 in package.json. The review feedback notes that this downgrade introduces critical compatibility issues with React 19, TypeScript configuration, and font imports, as well as known security vulnerabilities. It is recommended to upgrade to a stable, patched version of Next.js 15 (such as ^15.1.6) instead.
| "i18next-http-backend": "^3.0.2", | ||
| "motion": "^12.26.2", | ||
| "next": "^16.1.1", | ||
| "next": "14.1.1", |
There was a problem hiding this comment.
Downgrading next to 14.1.1 introduces critical compatibility and security issues:
- React 19 Incompatibility: The project uses
"react": "^19.2.3". Next.js 14 does not support React 19, which will cause peer dependency resolution failures and runtime crashes. - TypeScript Configuration: The project uses
next.config.ts, which is only natively supported in Next.js 15+. Next.js 14.1.1 will fail to load this configuration. - Font Imports:
app/layout.tsximportsGeistandGeist_Monofromnext/font/google, which are only available in Next.js 15+. - Security Vulnerabilities: Next.js
14.1.1itself contains known vulnerabilities (such as CVE-2024-34351) that were fixed in later releases (e.g.,14.2.4/14.1.5or later).
To resolve the CVEs while maintaining compatibility with React 19 and your current codebase, please upgrade to a patched, stable version of Next.js 15 (such as 15.1.6).
| "next": "14.1.1", | |
| "next": "^15.1.6", |
ce531ca to
4958f09
Compare
|
Hi team! Just checking in to see if you've had a chance to review this PR, or if there's any feedback or further changes needed to merge this. Thanks! |
This PR pins
nextto14.1.1to address CVEs. Re-opening to ensure the commit is properly signed from the start for the CI check. Closes #103