Fix "xref-pop-to-location: Marker does not point anywhere"#80
Merged
Conversation
Member
Avoid a possible error when jumping to a position in a file that is
out of bounds, due to the jumped-to file containing line number
directives. E.g., if target.ml's first line is "# 100 \"target.ml\"",
the right place to jump for line 100 would be the second physical line
of the file, but getting this right would be quite complex. As a
first step, just produce *some* valid position in the right buffer so
that xref-find-definitions does not fail completely.
The ultimate error manifests as:
xref-pop-to-location: Marker does not point anywhere
(and the xref-find-definitions command jumps to some random buffer):
due to the xref-location-marker method returning a marker that does
not point anywhere.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Avoid a possible error when jumping to a position in a file that is
out of bounds, due to the jumped-to file containing line number
directives. E.g., if target.ml's first line is "# 100 "target.ml"",
the right place to jump for line 100 would be the second physical line
of the file, but getting this right would be quite complex. As a
first step, just produce some valid position in the right buffer so
that xref-find-definitions does not fail completely.
The ultimate error manifests as:
(and the xref-find-definitions command jumps to some random buffer):
due to the xref-location-marker method returning a marker that does
not point anywhere.