Test windows support#87
Open
tmcgilchrist wants to merge 11 commits into
Open
Conversation
tmcgilchrist
force-pushed
the
windows-ci
branch
5 times, most recently
from
ef4e777 to
e7fd279
Compare
Add windows-latest to the CI matrix (OCaml 5.3 only). Remove `available: os != "win32"` from opam templates.
More robust means retry cursor, tolerate corrupt stream when process is shutdown. Provide a Windows utility to get the process_id back from the cursor handle. Windows is not Unix and Unix.create_process_env returns a handle on Windows not the PID.
tmcgilchrist
force-pushed
the
windows-ci
branch
from
0ab5ee7 to
f62e881
Compare
On Windows, Unix.kill takes a PID (uses OpenProcess) but Unix.waitpid takes the HANDLE returned by create_process (different values aka not-unix). The old code had it backwards in both places.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requires ocaml-multicore/hdr_histogram_ocaml#12