Show track rubbered state in the Weather overlay #17
Conversation
| useSessionStore, | ||
| (state) => | ||
| state.session?.SessionInfo?.Sessions?.find( | ||
| (session) => session.SessionNum === 0 |
There was a problem hiding this comment.
Why is it SessionNum 0? I think you should use current session number. Like for example here: https://github.com/tariknz/irdashies/blob/76b1ba72a8d829b4a3db9cb9175556e68b431eae/src/frontend/components/Standings/hooks/useSessionLapCount.tsx#L5-L6C23
There was a problem hiding this comment.
That's a good point sorry I missed that
There was a problem hiding this comment.
My fault for submitting unread code ;) I guess the effect is that you get stale track state for practice during qualy and race. I'll try to fix and submit a new PR later today when I get home
There was a problem hiding this comment.
I had a look at this, and the plot seriously thickened:
- State of every session can be set specifically or "carry over" from the previous one, the state then is literally "carry over"
- Officials are set as "carry over", AI and hosted can be set to specific states per session or carry over.
- I think it's better to know the initial state than to show "carry over".
- So as it is now it works perfectly for official races.
- To make it work for hosteds we would need logic to show the "last non carry over state". But this is not as trivial as just memoizing the latest valid state and showing the latest non-carry one, because what happens to someone who joins in qualy? we need to look back into past sessions to find a valid one.
I almost regret submitting this now 🤣
There was a problem hiding this comment.
I'm stupid it´s a very easy fix, I'll submit another PR with a sane handling of this
3 participants
I think this is nice to have, can confirm feelings of "slow track" on entering the session.
Could be elsewhere, and this is not strictly weather, but it´s "conditions"
I chose the icon to indicate "slipperyness", maybe there's a better one
I'm not sure about the formatting, those spans look sus to me, but CSS stumps me
Again this might be a toggle in the options, but can´t see anyone not wanting it