Adds the ability to scale the fontsize globally #21
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR introduces global font size scaling across dashboards by adding a new generalSettings configuration. Key changes include:
- Adding a GeneralSettings type to the dashboard layout.
- Creating a ThemeManager component to apply font size themes.
- Updating storage and settings components to merge and persist the new generalSettings.
Reviewed Changes
Copilot reviewed 16 out of 16 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/types/dashboardLayout.ts | Added a GeneralSettings interface with fontSize as a string union |
| src/frontend/theme.css | Introduced CSS classes for different font size themes |
| src/frontend/context/DashboardContext/DashboardContext.tsx | Added hook to access generalSettings |
| src/frontend/components/ThemeManager/ThemeManager.tsx | Wrapped children with theme-specific classes based on fontSize |
| src/frontend/components/Settings/types.ts | Updated GeneralSettings type (fontSize as number) – inconsistent with others |
| src/app/storage/* | Merged and persisted generalSettings in default and existing dashboards |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.