update logic for relative deltas, adds base work for speeds and avg laps #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tariknz
changed the title
tariknz
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the relative delta calculation in standings, and introduces foundational hooks and stores for computing per-car speeds and average lap times.
- Refactored
useDriverRelativesto use session-based lap-time estimation and a streamlined filter/slice pipeline. - Added
useCarIdxAverageLapTimeanduseCarIdxSpeedhooks with corresponding Zustand stores and comprehensive tests. - Aligned telemetry types (removing manual extensions) and tweaked test configs.
Reviewed Changes
Copilot reviewed 19 out of 19 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| vitest.config.ts | Removed explicit include so all specs under src/ run by default |
| src/types/telemetry.ts | Simplified Telemetry to mirror generated TelemetryVarList |
| src/frontend/context/index.ts | Exported new hooks useCarIdxSpeed & useCarIdxAverageLapTime |
| src/frontend/context/TelemetryStore/TelemetryStore.tsx | Updated setTelemetry signature to accept null |
| src/frontend/context/SessionStore/SessionStore.spec.tsx | Changed test assertions to cast directly as Session |
| src/frontend/context/LapTimesStore/useCarIdxAverageLapTime.ts | Implemented hook for per-car average lap times |
| src/frontend/context/LapTimesStore/useCarIdxAverageLapTime.spec.tsx | Added tests covering fallback & update logic |
| src/frontend/context/LapTimesStore/LapTimesStore.tsx | Built lap-times store with outlier filtering & median calculation |
| src/frontend/context/LapTimesStore/LapTimesStore.spec.tsx | Added exhaustive tests for lap-times buffering & stats |
| src/frontend/context/CarSpeedStore/useCarIdxSpeed.ts | Implemented hook for per-car speed calculation |
| src/frontend/context/CarSpeedStore/useCarIdxSpeed.spec.tsx | Added tests for speed update & caching behavior |
| src/frontend/context/CarSpeedStore/CarSpeedsStore.tsx | Built speed store with wrap-around handling & moving average |
| src/frontend/context/CarSpeedStore/CarSpeedsStore.spec.tsx | Added tests for buffer window & wrap-around scenarios |
| src/frontend/components/Standings/hooks/useDriverRelatives.tsx | Revamped relative‐delta logic and filtering around the player |
| src/frontend/components/Standings/hooks/useDriverRelatives.spec.tsx | Updated tests to reflect new delta and buffer behavior |
| src/frontend/components/Standings/Relative.tsx | Inserted spacing before <SessionFooter /> |
| src/app/irsdk/types/_GENERATED_telemetry.ts | Added optional TrackWetness to generated telemetry interface |
| .vscode/settings.json | Enabled eslint.useFlatConfig |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.