feat: round driver licence rating #35
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the DriverRatingBadge component to round the driver licence rating and format the displayed license string with a single decimal.
- Updated default license value to "R 0.0".
- Modified regex and formatting logic to round the license number to one decimal.
- Adjusted unit tests to expect the new formatting output.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/frontend/components/Standings/components/DriverRatingBadge/DriverRatingBadge.tsx | Updated default license value and revised license formatting logic to round to one decimal. |
| src/frontend/components/Standings/components/DriverRatingBadge/DriverRatingBadge.spec.tsx | Modified tests to match the new display output and added tests for rounding behavior. |
src/frontend/components/Standings/components/DriverRatingBadge/DriverRatingBadge.tsx
Outdated
Show resolved
Hide resolved
…/DriverRatingBadge.tsx Co-authored-by: Copilot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.