feat: hide FasterCarsFromBehind during Lone Qualify #44
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR hides the FasterCarsFromBehind component during "Lone Qualify" sessions and abstracts the component for better testability in Storybook. The changes improve component separation by creating a display component that can be independently tested and controlled.
- Adds session type check to hide component during "Lone Qualify" sessions
- Extracts display logic into a separate
FasterCarsFromBehindDisplaycomponent - Enhances Storybook configuration with controls for the display component
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| useCarBehind.tsx | Refactors hook to return classColor instead of computed background style |
| FasterCarsFromBehind.tsx | Adds session type check and extracts display component for better separation |
| FasterCarsFromBehind.stories.tsx | Updates Storybook to use display component with interactive controls |
src/frontend/components/FasterCarsFromBehind/hooks/useCarBehind.tsx
Outdated
Show resolved
Hide resolved
src/frontend/components/FasterCarsFromBehind/hooks/useCarBehind.tsx
Outdated
Show resolved
Hide resolved
…d.tsx Co-authored-by: Copilot <[email protected]>
…d.tsx Co-authored-by: Copilot <[email protected]>
tariknz
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
Screen.Recording.2025-07-16.at.8.56.21.AM.mov