fix: relative performance with sorting #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes performance issues in the driver relatives calculation by replacing inefficient array manipulation patterns with a more optimized approach. The changes eliminate redundant filtering and mapping operations while improving the sorting logic for relative positions.
- Refactored the driver filtering and mapping logic to reduce computational overhead
- Implemented separate sorting for drivers ahead and behind the player position
- Added proper filtering to handle NaN values for both relativePct and delta calculations
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/frontend/components/Standings/hooks/useDriverRelatives.tsx |
Optimized driver filtering and sorting logic to improve performance and fix relative position calculations |
src/frontend/components/Standings/hooks/useDriverPositions.tsx |
Minor formatting fixes for trailing commas in function calls |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.