Skip to content

Conversation

@tariknz
Copy link
Owner

@tariknz tariknz commented Jul 22, 2025

  1. Drivers to show around player
  2. Drivers to show in other classes
  3. Minimum drivers in player's class
  4. Top drivers to always show in player's class
image

Copilot AI review requested due to automatic review settings July 22, 2025 03:02
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds configurable settings for the standings widget to control how many drivers are displayed in different contexts. The changes introduce four new parameters that allow users to customize the driver visibility logic rather than relying on hardcoded values.

Key changes include:

  • Added four new driver standings configuration options with default values
  • Refactored the sliceRelevantDrivers function to use a Set-based approach for better performance and clarity
  • Updated the UI to provide input controls for each new setting

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
useDriverStandings.tsx Updated hook parameters to accept new optional configuration values
createStandings.ts Refactored sliceRelevantDrivers function with new parameters and Set-based logic
createStandings.spec.ts Added test cases for new configuration options
Standings.tsx Modified to use settings from configuration instead of hardcoded values
types.ts Added driverStandings configuration interface
StandingsSettings.tsx Added UI controls for new driver standings settings

@tariknz tariknz merged commit 166809b into main Jul 22, 2025
1 check passed
@tariknz tariknz deleted the fix/standings-minimum-drivers branch July 22, 2025 03:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants