-
Notifications
You must be signed in to change notification settings - Fork 16
Added toogle for hide and show the car number #64
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added toogle for hide and show the car number #64
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds a toggle feature to hide or show car numbers in both the standings and relative widgets. The author has noted a concern about losing the visual separator that car numbers provide between position and other data.
- Added
carNumberconfiguration option to both standings and relative widget settings - Made car number display conditional based on the toggle setting
- Updated default configurations to include the new car number toggle
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| DriverInfoRow.tsx | Made carNumber prop optional and conditionally renders the car number cell |
| Standings.tsx | Added conditional logic to pass carNumber based on settings |
| Relative.tsx | Added conditional logic to pass carNumber based on settings |
| types.ts | Added carNumber enabled boolean to both widget settings interfaces |
| StandingsSettings.tsx | Added toggle switch for car number visibility with migration logic |
| RelativeSettings.tsx | Added toggle switch for car number visibility with migration logic |
| defaultDashboard.ts | Added default carNumber enabled setting to dashboard configuration |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
src/frontend/components/Settings/sections/StandingsSettings.tsx
Outdated
Show resolved
Hide resolved
|
Looks good to me. Just regarding your note about the visual seperater I'm happy if you want to play around with it but I think it looks fine to me honestly. Just one small request can you include a demo/screenshot in the PR description so I can include it in the release notes. Other than that happy to approve and merge! |
Co-authored-by: Copilot <[email protected]>
…abPereira/irdashies into feat/toogle-for-car-number-
Done, i like more how i looks with the separator specially in multi class races |

I created as a draft PR just to check if this PR meats the expectations from codeowner.
Changelog:
Adding in relative and standing settings a toogle to enabled/disabled the car number.
My only concern with this is that we lost the visual separator, because car number serve as a column that separates the position with the rest of the data.
Screenshots:
Standings:
Multi class race:

Single class race:

Relatives:
Multi class race:

Single race: