ci/lint: convert lints to pre-commit & Ruff [stale] #391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
Contributor
|
I don't have merge permissions here, and the pre-commit CI failed. |
Borda
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
simplify the linting with easier-to-read pre-commit, which can also be installed as a bot (which may commit linting fixes to open PRs)
With his pre-commit, we also explicitly set used versions, so there are sudden issues due to the recently released new linter version
Moreover, wrapping several linters and formatted to Ruff rule, which is a much faster tool:
flake8-> rule 'E', 'F', 'W'isort-> rule 'I'pyupgrade-> rule 'UP'bandit-> rule 'S'bugbear-> rule 'B'comprehensions-> rule 'C4'cc: @tartley @hugovk