-
-
Notifications
You must be signed in to change notification settings - Fork 268
Drop support for EOL Python 2.7-3.8 #409
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you @hugovk ! |
|
@hugovk If you happen to also look at the lint failures, be aware that my vague preferences are:
I'm happy to chat about alternative ideas on any of the above, but those would be my vague preferences. |
|
@hugovk Also, huge thanks for the contributions, but be aware that colorama is sort of easing into a graceful retirement. I haven't used Windows in over a decade, at least, and the need for colorama it is much diminished these days (modern windows terminals all display ANSI codes just fine), so I mostly think that its current install base comes from projects who installed it long ago when it was more useful, and have never had incentive to remove it since. Since that install base is so large and includes important projects, I'm super keen not to break them. So new features in Colorama have a very high bar to be accepted. In particular, lots of people have been keen to add features extending the convenience helpers like Fore.RED, to help callers generate ASCI codes or the windows equivalents. However, in general I'm not keen to flesh out generation of all the possible ANSI codes in colorama. My philosophy is that colorama should do one thing well, and that one thing is converting ANSI codes into windows equivalents. If callers want convenience wrappers to help them generate the ANSI codes in the first place, then they should look at the MUCH more capable alternatives like rich, click, blessings, etc. I regret even including Fore.RED, etc, in colorama at all. Best. Jonathan. |
|
@hugovk UPDATE: A third preference for lint checks in CI: Changes should facilitate devs being able to run all CI checks locally, for example by the github actions running things like 'make lint'. Then it is guaranteed EASY for devs to run the checks locally, and to be sure that they results they see are the SAME results that will occur in CI. |
I agree. I've only seen
Yep, looks like many of them can be replaced. Let's look at this after 1.
Also sounds good, can be done either before or after 2. Re: graceful retirement, yeah, I saw #300. A safe "maintenance mode" without new features sounds reasonable and it's good to transparent about it and careful about compatibility 👍 |
Follow on from #403 (comment)
Python 2.7-3.8 are EOL:
https://devguide.python.org/versions/
2.7 and 3.7 are also no longer available on GitHub Actions causing the CI to fail. This PR also takes the opportunity to drop EOL 3.8.
This allows future improvements such as f-strings.