This repository was archived by the owner on Nov 1, 2022. It is now read-only.
Create constants.py#25
Open
CodeLongAndProsper90 wants to merge 3 commits into
Open
Conversation
koutoftimer
suggested changes
Sep 8, 2021
koutoftimer
left a comment
koutoftimer
left a comment
There was a problem hiding this comment.
This changes have to revised carefully.
Comment on lines
-24
to
-25
| img_dir = path.join(path.dirname(__file__), 'assets') | ||
| sound_folder = path.join(path.dirname(__file__), 'sounds') |
There was a problem hiding this comment.
You have removed this two completely, why?
img_dir is a used constant.
Comment on lines
+1
to
+6
| ## initialize pygame and create window | ||
| pygame.init() | ||
| pygame.mixer.init() ## For sound | ||
| screen = pygame.display.set_mode((WIDTH, HEIGHT)) | ||
| pygame.display.set_caption("Space Shooter") | ||
| clock = pygame.time.Clock() ## For syncing the FPS |
There was a problem hiding this comment.
If someone runs python <path to>/spaceShooter.py what result will be? It looks like this code is not required because it does nothing in this case.
Plus: where do you have constants WIDTH and HEIGHT from? Where is pygame import?
Looks like total nonsense and should be removed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.