fix: get_artifact_from_index now uses artifact_path instead of index_path(bug 1999039) #874
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcristau
requested changes
Dec 9, 2025
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
Please add a test.
Also the auth failure happens in the bug happens on the findArtifactFromTask call prior to the line you're changing, with tc saying "Cannot use two authentication schemes at once this request has both bewit in querystring and 'authorization' header". I don't think this can fix that.
abhishekmadan30
force-pushed
the
fixing-find-task-id-batch
branch
from
9ae51f3 to
ec691c2
Compare
abhishekmadan30
changed the title
Contributor
Author
|
I updated the bug number attached to this as they split the bugs. This is a fix for TypeError: '_io.BytesIO' object is not subscriptable. I will create a separate patch for auth failure |
jcristau
requested changes
Dec 10, 2025
Contributor
jcristau
left a comment
jcristau
left a comment
There was a problem hiding this comment.
The test doesn't seem adequate, it passes without the get_artifact_from_index change.
…path(bug 1999039)
abhishekmadan30
force-pushed
the
fixing-find-task-id-batch
branch
from
ec691c2 to
71412b4
Compare
jcristau
approved these changes
Dec 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.