feat(Worker): Adds two otel span attributes when processJob is called #3199
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -830,6 +830,8 @@ will never work with more accuracy than 1ms. */ | |||
| [TelemetryAttributes.WorkerId]: this.id, | |||
| [TelemetryAttributes.WorkerName]: this.opts.name, | |||
| [TelemetryAttributes.JobId]: job.id, | |||
| [TelemetryAttributes.JobName]: job.name, | |||
There was a problem hiding this comment.
TelemetryAttributes.JobName is used in the Worker class but is not defined in the TelemetryAttributes enum. Consider adding a definition for JobName in src/enums/telemetry-attributes.ts.
Copilot uses AI. Check for mistakes.
There was a problem hiding this comment.
It is actually, just not added in this PR though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This change isn't strictly necessary but adds two span attributes to the open telemetry tracing when a job is being processed. These additional pieces of metadata could be very helpful when troubleshooting issues.
How
I added the two span attributes I'd like see.
Additional Notes (Optional)
I don't have a good local setup to test this. The changes seem pretty straightforward, but I will lean on maintainers to validate.