feat(job): add moveToCompleted method [python] #3251
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roggervalf
force-pushed
the
feat-job-move-to-completed
branch
from
5bf5d2b to
c145d61
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new moveToCompleted method on the Job instance to support manual processing.
- Adds moveToCompleted tests for both JavaScript and Python workers.
- Refactors related functions in the Scripts and Worker modules to simplify moveToCompleted/Failed processing.
- Updates the Job class to expose the new moveToCompleted behavior.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_worker.ts | Adds assertions on attemptsMade and finishedOn for JS tests. |
| python/tests/worker_test.py | Introduces a test for manual processing and verifies job properties. |
| python/bullmq/worker.py | Updates moveToCompleted invocation; removes unused opts parameter. |
| python/bullmq/scripts.py | Refactors moveToCompleted and moveToFailed methods and their args. |
| python/bullmq/job.py | Implements moveToCompleted to update job status and properties. |
roggervalf
force-pushed
the
feat-job-move-to-completed
branch
from
9bdf684 to
ed79d61
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
How
Additional Notes (Optional)
Any extra info here.