Add connections CRUD endpoints#6
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an authenticated, in-memory Connections API to the remote provider scaffold to support local development and Meshery remote-provider contract testing.
Changes:
- Introduces
/api/connectionsand/api/connections/{id}CRUD endpoints backed by an in-memory store. - Extends capabilities metadata and README to advertise the new “connections” feature and endpoints.
- Adds end-to-end CRUD tests covering authorization, create/list/get/update/delete flows.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| README.md | Documents the new Connections CRUD endpoints and supported query/payload formats. |
| internal/provider/server.go | Registers connections routes and advertises the connections capability. |
| internal/provider/server_test.go | Adds tests for the connections capability advertisement and full CRUD behavior. |
| internal/provider/connections.go | Implements in-memory connection store plus list/create/get/update/delete handlers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+61
to
+65
| s.mux.HandleFunc("GET /api/connections", s.handleConnections) | ||
| s.mux.HandleFunc("POST /api/connections", s.handleConnections) | ||
| s.mux.HandleFunc("GET /api/connections/{id}", s.handleConnectionByID) | ||
| s.mux.HandleFunc("PUT /api/connections/{id}", s.handleConnectionByID) | ||
| s.mux.HandleFunc("DELETE /api/connections/{id}", s.handleConnectionByID) |
Comment on lines
+258
to
+261
| query := r.URL.Query() | ||
| page := parsePositiveInt(query.Get("page"), 1) | ||
| pageSize := parsePositiveInt(firstNonEmpty(query.Get("pageSize"), query.Get("pagesize")), 0) | ||
| search := firstNonEmpty(query.Get("search"), query.Get("q")) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.