Align credential collection responses with connection-style paging#9
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR aligns the Credentials collection list endpoint with the existing Connections-style paging by adding server-side search + pagination and returning both camelCase and snake_case pagination keys for compatibility.
Changes:
- Add
page/pageSize(pagesize) pagination andsearch(q) filtering forGET /api/credentials. - Return
page_sizeandtotal_countaliases alongsidepageSizeandtotalCountin the credentials list response. - Document the supported query parameters and add a test covering filtered/paged credentials listing.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| README.md | Documents credentials list query params and response paging key compatibility. |
| internal/provider/server_test.go | Adds test coverage for credentials list search + pagination + snake_case alias. |
| internal/provider/credentials.go | Implements query parsing, filtered paging logic, total counting, and search matching. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+80
to
+90
| start := (page - 1) * pageSize | ||
| if start >= len(items) { | ||
| return []credentialRecord{} | ||
| } | ||
|
|
||
| end := start + pageSize | ||
| if end > len(items) { | ||
| end = len(items) | ||
| } | ||
|
|
||
| return items[start:end] |
hortison
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Notes
feat/credentials-items.