feat(vpc): AWS VPC Terraform module with multi-AZ support#7
Merged
Conversation
- Public/private subnet tiers across configurable AZs - NAT gateway: single or per-AZ HA mode (single_nat_gateway var) - VPC flow logs to CloudWatch with configurable retention - Required TCS tags applied via merge() on all resources - Private route table IDs exposed as output for VPC endpoint callers - Example in examples/vpc-basic/ Signed-off-by: Hamza Mohammed <hamza-mohd@users.noreply.github.com>
arjunmehta-git
commented
May 27, 2026
arjunmehta-git
left a comment
arjunmehta-git
left a comment
Member
Author
There was a problem hiding this comment.
Overall solid. The private route table ID output is a good addition - I've had to hack around the lack of that before.
Two small things:
- The flow log IAM role name is hardcoded - if this module is used twice in one account, the role name collides. Make it
${var.vpc_name}-flow-log-roleor accept a variable. - In the example, show the
tagsvariable being populated - new users won't know what the required TCS tags are otherwise.
sarajkrishnasingh
approved these changes
May 27, 2026
sarajkrishnasingh
left a comment
sarajkrishnasingh
left a comment
Member
There was a problem hiding this comment.
LGTM. Flow log setup is clean. IAM role naming is worth fixing but can be a quick follow-up. Approving.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds reusable Terraform VPC module. Closes #4.
Changes
modules/vpc/- Full VPC module (subnets, NAT, flow logs, tagging)examples/vpc-basic/- Dev environment example with single NATTesting
Validated in us-east-1 with 2 AZs, single NAT mode.
Checklist
terraform fmtcleanterraform validatepasses