feat(iam): IAM baseline roles module#8
Merged
Merged
Conversation
- ReadOnly, Developer, PlatformEngineer, CICD, BreakGlass roles - Resource-scoped iam:PassRole for developer role (tcs-* prefix) - OIDC trust for GitHub Actions on CICD role - MFA enforcement on all human-assumed roles - Optional CloudWatch alarm on BreakGlass assumption Signed-off-by: Hamza Mohammed <hamza-mohd@users.noreply.github.com>
arjunmehta-git
commented
May 27, 2026
arjunmehta-git
left a comment
arjunmehta-git
left a comment
Member
Author
There was a problem hiding this comment.
The OIDC setup looks correct. One thing worth documenting in the README: the subject claim format matters. repo:org/repo:* is broad - for production, teams should scope it to specific branches or environments (e.g. repo:org/repo:ref:refs/heads/main).
winkletinkle
approved these changes
May 27, 2026
winkletinkle
left a comment
winkletinkle
left a comment
Member
There was a problem hiding this comment.
Reviewed the BreakGlass alarm implementation - looks right. The MFA condition in the trust policy uses the correct key (aws:MultiFactorAuthPresent). LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Implements the IAM baseline from the design discussion. Closes #5.
Roles
Notes
tcs-*prefix only