fix: resolve several issues in message router #348
+42
−23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensures behavior matches the original CEF C++ implementation by adding early returns when maps are empty or entries are missing. This fixes a panic in `BrowserSideRouter::find_browser_all`. Reference C++ implementation: - BrowserSideRouter: https://github.com/chromiumembedded/cef/blob/5f93c2b090d19659451de4dfe44896ad7dbfd832/libcef_dll/wrapper/cef_message_router.cc#L535-L537 - BrowserInfoMap: https://github.com/chromiumembedded/cef/blob/5f93c2b090d19659451de4dfe44896ad7dbfd832/libcef_dll/wrapper/cef_browser_info_map.h#L159-L167
…m RendererSideRouter When sending a success response back to JavaScript, MessagePayload::String should be created as a V8 string to match the original CEF behavior. This commit fixes the issue where MessagePayload::String was incorrectly handled as binary data.
…ge-router-patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This Pull Request addresses critical issues in the Message Router component to align its behavior with the original CEF C++ implementation. These fixes prevent application panics during startup and ensure correct data type mapping for IPC responses.
Linked Issues
MessageRouter/BrowserInfoMap::find_browser_allduring startup #346 (Panic in BrowserInfoMap)RendererSideRouteralways returnsArrayBufferto JS instead of string for success responses #347 (Incorrect response type in RendererSideRouter)Changes
Added missing early returns in
BrowserSideRouterandBrowserInfoMap.expect("missing browser info map")when navigation occurs before the router is fully initialized.Fixed response type mapping in
RendererSideRouterexecute_success_callbackto returnMessagePayload::Stringas a V8 string instead of anArrayBuffer.onSuccesscallback receives a proper string, matching standard CEF behavior.Verification
Verified using a port of the official CEF
message_routerexample: tasuren/cef-rs-message-router[object ArrayBuffer]to JavaScript.