Skip to content

remove token for oidc token publishing#934

Open
jbolda wants to merge 1 commit into
devfrom
odic-publishing
Open

remove token for oidc token publishing#934
jbolda wants to merge 1 commit into
devfrom
odic-publishing

Conversation

@jbolda

@jbolda jbolda commented Nov 1, 2025

Copy link
Copy Markdown
Member

Motivation

We have enabled trusted publishing. With this, we need to give it perms to create the token and then remove setting it.

@github-actions

github-actions Bot commented Nov 1, 2025

Copy link
Copy Markdown
Contributor

Package Changes Through 839a0dc

There are 2 changes which include create-tauri-app with patch, create-tauri-app-js with patch

Planned Package Versions

The following package releases are the planned based on the context of changes in this pull request.

package current next
create-tauri-app 4.6.2 4.6.3
create-tauri-app-js 4.6.2 4.6.3

Add another change file through the GitHub UI by following this link.


Read about change files or the docs at github.com/jbolda/covector

- name: Publish
run: |
echo "//registry.npmjs.org/:_authToken=$NPM_TOKEN" >> ~/.npmrc
npm publish

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@amrbashir I don't understand the reason that we were calling publish twice. Any recollection?

@amrbashir amrbashir Nov 1, 2025

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we are releasing two packages here, create-tauri-app and create-tauri

this way users can do pnpm create tauri or pnpm create tauri-app but iirc the primary reason was to squat create-tauri and avoid having it fall in the hands of a malicious squatter.

@Legend-Master

Copy link
Copy Markdown
Contributor

@jbolda Hey, I would like to publish a new version soon, could we revert the removed npm publish and get this merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants