Repository navigation
feat: Optimize search requests with AbortController - #209
Merged
amrbashir merged 1 commit intoMay 6, 2026
Merged
Conversation
amrbashir
reviewed
Apr 2, 2026
amrbashir
left a comment
Member
There was a problem hiding this comment.
Apologoies for the late reply, I left a few comments. Could you also add a change file in .changes directory similar to this one https://github.com/tauri-apps/meilisearch-docsearch/blob/e5c670756e46f1f785b9c7a694eb337f5f4ce690/.changes/check-composition-event.md?plain=1
tony140407
force-pushed
the
feat/optimize-search-requests
branch
from
May 6, 2026 03:03
0ec6d9a to
e9b4b30
Compare
tony140407
force-pushed
the
feat/optimize-search-requests
branch
from
May 6, 2026 03:14
e9b4b30 to
eadf364
Compare
Contributor
Author
|
@amrbashir Thanks for the review! I've addressed all the feedback:
Ready for another look when you have a chance. |
amrbashir
approved these changes
May 6, 2026
Member
|
Thank you |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Motivation
Currently, when users type quickly in the search box, multiple API requests
are sent simultaneously. This can cause:
🔧 Changes
AbortControllerto cancel previous search requests when a new one startssignalto the Meilisearch SDK search method (3rd parameter)AbortErrorgracefully without showing error statesonReset()calls in error handlers that could cancel active requests✅ Testing
Tested with:
📸 Screenshots
Happy to make any adjustments based on feedback! 😊